Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lexical-binding in parseclj-lex.el as well #41

Merged
merged 1 commit into from Dec 3, 2023
Merged

Use lexical-binding in parseclj-lex.el as well #41

merged 1 commit into from Dec 3, 2023

Conversation

tarsius
Copy link
Contributor

@tarsius tarsius commented Dec 3, 2023

No description provided.

@vemv vemv marked this pull request as draft December 3, 2023 17:09
@vemv
Copy link
Member

vemv commented Dec 3, 2023

Thanks for the PR!

While I'd imagine that this would pass 99 out of 100 times, I would err on the side of cautiousness and leave it as-is.

Especially as parseclj/parseedn move at a slower pace.

@tarsius
Copy link
Contributor Author

tarsius commented Dec 3, 2023 •
edited

Meanwhile, could you please add -*- lexical-binding: nil; -*-. In Emacs 30, the byte-compiler started complaining if the variable isn't explicitly set to either of the valid values. Thanks!

@vemv
Copy link
Member

vemv commented Dec 3, 2023

Got it, TIL. Feel free to add it and I'll merge it in!

tarsius added a commit to tarsiiformes/parseclj that referenced this pull request Dec 3, 2023
@tarsius
Set lexical-binding in parseclj-lex.el
fc8008e 
This silence Emacs 30's byte-compiler, which insists on this variable
being set in every file.  Stick to not enabling lexical-bindings for
now, see clojure-emacs#41.
@tarsius
Copy link
Contributor Author

tarsius commented Dec 3, 2023

I've updated the commit.

@tarsius tarsius marked this pull request as ready for review December 3, 2023 18:12
@tarsius
Copy link
Contributor Author

tarsius commented Dec 3, 2023 •
edited

Ups, one moment please.

Listening to Emacsconf talks while coding...

@tarsius
Set lexical-binding in parseclj-lex.el
0a8ef86 
This silence Emacs 30's byte-compiler, which insists on this variable
being set in every file.  Stick to not enabling lexical-bindings for
now, see clojure-emacs#41.
@tarsius
Copy link
Contributor Author

tarsius commented Dec 3, 2023

Good to go now 😁

@vemv vemv merged commit a5302bd into clojure-emacs:main Dec 3, 2023
@vemv
Copy link
Member

vemv commented Dec 3, 2023

Thanks!

I'll cut a release. A stable CIDER release including it may not be created until later next week.

@tarsius tarsius deleted the lexical branch December 3, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tarsius @vemv