Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upArmor against actually trash URLs #190
Comments
arrdem
added
the
enhancement
label
Mar 31, 2015
arrdem
modified the milestone:
0.4.16
Apr 1, 2015
arrdem
modified the milestones:
0.4.16,
0.4.17
Apr 26, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
arrdem
Dec 12, 2016
Contributor
I'm just gonna punt on this. Most of the 404s that Grimoire gets are from reeeeally stale old links which got broken by accident and are being visited by a crawler of some sort. The optimistic ones are users searching for documentation which I don't host (clojurescript) or newer versions (Clojure alpha builds) and in neither case is there really a sane way to recover.
|
I'm just gonna punt on this. Most of the 404s that Grimoire gets are from reeeeally stale old links which got broken by accident and are being visited by a crawler of some sort. The optimistic ones are users searching for documentation which I don't host (clojurescript) or newer versions (Clojure alpha builds) and in neither case is there really a sane way to recover. |
arrdem commentedMar 31, 2015
Ex.
The root of these various failures seems to be that the version part of the path is insufficiently validated. That should be pretty easy to fix up. Right now, the invalid version string causes an actual unhandled exception on the Grimoire side.