Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use load instead of require to load core cljs macros
Loading now happens dynamically and once when the analyzer is first ran. Also provides macros to facilitate overriding of the default path provided (defaults to cljs/core).
- Loading branch information
1 parent
f30cd5e
commit b261447
Showing
1 changed file
with
29 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b261447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raph-amiard! I'm working on a bit of a refactor to the state changed and maintained by the cljs compiler (see CLJS-643, with progress happening over here), and I have a question about the cljs-macro-loading bits that you put together in this commit: what are the use cases that this load redirection supports? I have some guesses (and maybe @swannodette knows, too), but thought it'd be worth asking the source.
(BTW, I'm not planning on changing this for CLJS-643 at all, just trying to grok more of the internals.)
b261447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was just to parameterize how macros are loaded, this was to allow Lua ClojureScript to reuse analyzer.clj.
b261447
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, figured it was "emitter"-related, thanks, I had forgotten about clojurescript-lua.