Just a small change to make debugging the bootstrap process easier #10

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@DerGuteMoritz

See the commit.

@swannodette
Member

ClojureScript doesn't take pull requests. What error were you encountering that you needed to debug? Thanks.

@DerGuteMoritz

What's the correct way for contributing then?

I can't remember what error it was exactly. The thing is that without -e the script will execute until the end regardless of any errors it encounters, e.g. when the maven server is temporarily down users will get a screen full of output which they have to dissect in order to find out that it fails right at the beginning. With -e it will exit after the first non-zero exit code. I'd say it's good practice to include this flag in any case. Fail early, fail noisily, and all that!

@swannodette
Member

Point taken. ClojureScript loves contributions - but you need to send in your CA, and then you can submit patches via JIRA.

@DerGuteMoritz

I doubt that this small change is affected by copyright in any way, and it certainly isn't in Germany where this patch was manufactured. If possible at all, I am hereby placing my change in the public domain for legislations which have such a concept :-) I'll maybe do the CA paperwork if I have any substantial contributions to make.

@swannodette
Member

Bootstrap script fixed in master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment