Fixed bug in trace-ns/untrace-ns macros. #2

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

MrGung commented Sep 27, 2012

Otherwise ClassNotFoundExceptions are thrown.

Fixed trace-ns/untrace-ns macros.
Otherwise ClassNotFoundExceptions are thrown.
Contributor

lprefontaine commented Sep 28, 2012

Hi Steffen,

the unquote is required to macro expand the ns argument passed to the macro.
If not unquoted, the unit test will not even compile.

Can you provide more information about the context in which you ran into this problem ?
I would also suggest to use trace-ns* directly to toss the macro aside temporarily.
Just quote the name space argument when you call it. The macro is only syntactic sugar. trace-ns* does the
work.

Send extra info to lprefontaine@softaddicts.ca.

Pull requests are not accepted. If you want to contribute, you need to send a signed CA and get the
necessary accesses from Clojure core to contribute. This is why I am closing it. If you have further
problem, report them on the Clojure mailing list so everyone will hear about them.

Thank you,
Luc P.

MrGung commented Sep 28, 2012

Hi Luc,

of course you are right. I had a problem with that code at work - somehow fixed it - and tried to reproduce the change to the code at home, issuing the pull request (without running the tests).
I was wrong with my home-work.

Sorry for that - more diligence next time.

Best,
Steffen

Contributor

lprefontaine commented Sep 28, 2012

No problem, have a nice weekend (if not already started)

Luc

Hi Luc,

of course you are right. I had a problem with that code at work - somehow fixed it - and tried to reproduce the change to the code at home, issuing the pull request (without running the tests).
I was wrong with my home-work.

Sorry for that - more diligence next time.

Best,
Steffen


Reply to this email directly or view it on GitHub:

#2 (comment)

Softaddictslprefontaine@softaddicts.ca sent by ibisMail from my ipad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment