fix #ecosystem link #89

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@ghost
Contributor

ghost commented Jan 30, 2013

actually, trying this:
http://clojure-doc.org/articles/content.html#the_ecosystem
in firefox 19.0, either by copy/pasting or directly linking, still doesn't scroll down to it, but only after Alt+D to select the address field and pressing Enter does work, however I'm sure this is another matter, likely just firefox related.
The fix still applies though.

@ghost
Contributor

ghost commented Jan 30, 2013

btw, is there any way that you could write this content.md file which this patch changes, so that the # parts in parenthesis are always computer from the previous [] content
ie.
* [The Ecosystem](#the_ecosystem) (tools, libraries, community, books) guides
#the_ecosystem should be auto computer from [The Ecosystem] by removing [] and replacing spaces with underscores, and it looks like it's a must to also lowercase all chars.

EDIT: I guess what I mean is, that having to manually keep track of the # links (as in above) and making sure they are updated every time someone changes the name of the ie. "The Ecosystem" (while previously maybe it was just "Ecosystem") is well, I don't know inconsistent? the system itself is simply not something that I'd want to play with :) and I'm personally having trouble accepting any such systems(which is like all of the existing ones that I'm aware of) but that's obviously my problem ;) //rant

Owner

michaelklishin commented Jan 30, 2013

It was already fixed in master.

@ghost
Contributor

ghost commented Jan 30, 2013

it doesn't seem like it, unless you mean, on your local master which wasn't pushed?

Owner

michaelklishin commented Jan 30, 2013

The "Ecosystem and Tools" link on the home page points to here, with the correct (#the_ecosystem) hash. And it works as expected
in Chrome and Safari.

@ghost
Contributor

ghost commented Jan 30, 2013

ok, that's true the one on the rightleft does point to that, but the one on the page doesn't
Files Changed tab here in pull request, is always a good way to see the diff

michaelklishin pushed a commit that referenced this pull request Jan 30, 2013

Owner

michaelklishin commented Jan 30, 2013

Should be good now. We can generate that list with JavaScript like we do with page ToCs but I doubt it is worth it,
those sections do not change often enough any more.

@ghost
Contributor

ghost commented Jan 30, 2013

You're right, it's not worth it just for this.
Cheers, thanks.

Contributor

uvtc commented Jan 30, 2013

AtKaaZ, you asked if you could just write [Foo bar] instead of [Foo bar](#foo-bar). Recent versions of Pandoc have this feature, but the tools which process CDS don't appear to.

@ghost
Contributor

ghost commented Jan 30, 2013

Thank you, I'll make sure to check that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment