New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing "remove aliases" in native client #98

Merged
merged 1 commit into from Jul 16, 2014

Conversation

Projects
None yet
2 participants
@oliyh

oliyh commented Jul 16, 2014

Hi,
The "remove aliases" functionality does not work with the native client as described in the documentation. This is mainly due to the incorrect destructuring being used in apply-remove-alias but the differently named keys (index vs indices, alias vs aliases) in the documentation was also very confusing.

I've fixed the destructuring, updated the documentation to give a working example and added a test.

Thanks!

michaelklishin added a commit that referenced this pull request Jul 16, 2014

Merge pull request #98 from oliyh/master
Fixing "remove aliases" in native client

@michaelklishin michaelklishin merged commit 9896583 into clojurewerkz:master Jul 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin
Member

michaelklishin commented Jul 16, 2014

👍

@michaelklishin

This comment has been minimized.

Show comment
Hide comment
@michaelklishin

michaelklishin Jul 16, 2014

Member

@oliyh can you please update ChangeLog.md and guides (if needed, major brownie points for documenting this piece if we don't have any docs for it)?

I'll release 2.1.0-beta4 later today.

Member

michaelklishin commented Jul 16, 2014

@oliyh can you please update ChangeLog.md and guides (if needed, major brownie points for documenting this piece if we don't have any docs for it)?

I'll release 2.1.0-beta4 later today.

@oliyh

This comment has been minimized.

Show comment
Hide comment
@oliyh

oliyh Jul 16, 2014

Sure, I can update the changelog and docs - will do so in a short while

oliyh commented Jul 16, 2014

Sure, I can update the changelog and docs - will do so in a short while

oliyh added a commit to oliyh/elastisch that referenced this pull request Jul 16, 2014

oliyh added a commit to oliyh/elastisch that referenced this pull request Jul 16, 2014

michaelklishin added a commit that referenced this pull request Jul 16, 2014

Merge pull request #99 from oliyh/master
Updating changelog to reflect inclusion of #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment