Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest update never stops loading #46

Closed
Leithian opened this issue May 6, 2022 · 18 comments
Closed

Newest update never stops loading #46

Leithian opened this issue May 6, 2022 · 18 comments

Comments

@Leithian
Copy link

Leithian commented May 6, 2022

Describe the bug
Since the latest update, the dashboard screen doesn't load anymore, except the "pause" button. Also, the file thumbnails in the file explorer don't work anymore.
Also the printer settings only show a grey screen.

To Reproduce
Steps to reproduce the behavior:

  1. Open the app
  2. Never finish loading

Expected behavior
Seeing the dashboard

Screenshots
Screenshot_20220506-145403
Screenshot_20220506-145424

Smartphone (please complete the following information):

  • Device: Pixel 4XL
  • OS: Android
  • Version: 12

Mobileraker-Version
1.6.0-12

Klipper versions

  • Klipper: v0.10.0-391-g722ad4a1
  • Moonraker: v0.7.1-565-gfcfa563
@Clon1998
Copy link
Owner

Clon1998 commented May 6, 2022

Hey, thanks for the feedback.
Did you upgrade or installed the app freshly?
If the first one is the case, can you test if the problem resolves by deleting the apps data and setting up the printer again?
I am pretty sure it's cause by the migration from local storage to Moonraker storage of the printer settings.

@Leithian
Copy link
Author

Leithian commented May 6, 2022

Yes, I upgraded, but also clearing the app data and setting it up again doesn't change what I get to see, the console and file viewer work but the dashboard doesn't.

@Clon1998
Copy link
Owner

Clon1998 commented May 6, 2022

Interesting 🤔
I'll take a closer look at that tomorrow.
I need to setup an older version and test if sth. is still wrong with the settings migration.
Since the settings screen is not working and the dashboard is the only screen using the printer`s setting I am sure sth. is wrong there.

@padok
Copy link

padok commented May 6, 2022

I also have this problem, in addition (I don't know if it's related) I can no longer open the printer settings to add a camera for example. It shows the settings for about 3-4s and then the screen turns completely gray, as shown below:

2022-05-06 17 53 27

Smartphone (please complete the following information):

Device: OnePlus 6t
OS: Android
Version: 11

@Leithian
Copy link
Author

Leithian commented May 6, 2022

I think it might be related, as I also have the same issue with the printer settings.

@Clon1998
Copy link
Owner

Clon1998 commented May 6, 2022

Interesting that none of the RC testers reported the issue. However that's why I published a beta build to the store.
I now know that it's definitely related to the migration from local to remote storage for the printer settings.
I'll see if I am able to fix the issue until tomorrow.
Thanks for the feedback guys.
I'll let you guys know once I've published a new beta release fixing the issue.

@Leithian
Copy link
Author

Leithian commented May 6, 2022

I just found something, that I don't know how to make sense of: When I clear the app data, the printer gets removed as expected. But if clear app data, verify in the app that I would have to re-add my printer, uninstall and reinstall, my printer is back. Is there some storage through google cloud or something?

@Clon1998
Copy link
Owner

Clon1998 commented May 6, 2022

I just found something, that I don't know how to make sense of: When I clear the app data, the printer gets removed as expected. But if clear app data, verify in the app that I would have to re-add my printer, uninstall and reinstall, my printer is back. Is there some storage through google cloud or something?

No cloud-based sync. Hive, the library I am using to persist data on a device is handling that. Internaly Hive uses Android's shared preferences to store your data. As far as I know, the shared preference file created by an app is not removed during the removal/uninstall of the app. Thats why the settings are still available, even after deleting the app.

@Clon1998
Copy link
Owner

Clon1998 commented May 6, 2022

I just pushed the fix with 05e46a9.
The problem was caused by a missing catch clause, resulting in an error while trying to fetch the settings for your printer (Presets, Invert-x,y,z ....).
I'll submit the a new beta build to the playstore.
Let me know if this fixes your issues.

@Clon1998 Clon1998 closed this as completed May 6, 2022
@Clon1998 Clon1998 reopened this May 6, 2022
@Leithian
Copy link
Author

Leithian commented May 6, 2022

But still it seems weird that I can delete my app data, don't see the printer in the app, uninstall and reinstall it and then get the printer back, even though the last state the app was in was without a printer...

@Clon1998
Copy link
Owner

Clon1998 commented May 6, 2022

But still it seems weird that I can delete my app data, don't see the printer in the app, uninstall and reinstall it and then get the printer back, even though the last state the app was in was without a printer...

Well, that's definitely weird.
I have no explanation for that behaviour. However, I can guarantee you that no cloud sync is involved in mobileraker at the moment, you can always check the source code here.

@Leithian
Copy link
Author

Leithian commented May 6, 2022

However, I can guarantee you that no cloud sync is involved in mobileraker at the moment, you can always check the source code here.

I believe you, cloud sync was just the first somewhat logical explanation for this behaviour.

Thanks for the quick fix, I'll try it as soon as it's available!

@Clon1998 Clon1998 closed this as completed May 6, 2022
@Clon1998 Clon1998 reopened this May 6, 2022
@padok
Copy link

padok commented May 7, 2022

I can confirm, that the latest beta does fix the printer settings and the dashboard for me. Now only my cameras mjpg stream is does not load, but that could be user error.

@Leithian
Copy link
Author

Leithian commented May 7, 2022

I can also confirm that the dashboard and printer settings are fixed. For me, even the webcam is working, but the thumbnails in the file explorer are still not loading.

@Clon1998
Copy link
Owner

Clon1998 commented May 7, 2022

I can confirm, that the latest beta does fix the printer settings and the dashboard for me. Now only my cameras mjpg stream is does not load, but that could be user error.

Regarding the MJPEG stream, ensure that the correct address is set!
The cam is working on my side.

@Clon1998
Copy link
Owner

Clon1998 commented May 7, 2022

I can also confirm that the dashboard and printer settings are fixed. For me, even the webcam is working, but the thumbnails in the file explorer are still not loading.

I always receive the thumbnail images directly from moonraker. This is also working fine on my devices and also on the emulator.

@Clon1998
Copy link
Owner

@Leithian, @padok did you guys manage to resolve your issues?
So far I did not receive feedback regarding your issues.

@padok
Copy link

padok commented May 11, 2022

Yes, for me the problem is solved, I switched my camera proxy to snapshot mode and my camera is also working again.
Thanks a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants