New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Don't crash if Slack does not return JSON #21

Merged
merged 1 commit into from Jul 13, 2015

Conversation

Projects
None yet
3 participants
@kevinburkeshyp
Copy link
Collaborator

kevinburkeshyp commented Jun 30, 2015

Sometimes Slack doesn't return JSON for an API response, if they're having
a bad day. Catch parsing errors and hit the callback with the error instead of
(potentially) crashing the process.

api: Don't crash if Slack does not return JSON
Sometimes Slack doesn't return JSON for an API response, if they're having
errors. Catch parsing errors and hit the callback with the error instead of
(potentially) crashing the process.
@kevinburkeshyp

This comment has been minimized.

Copy link
Collaborator

kevinburkeshyp commented Jun 30, 2015

(this just crashed a process on our server)

clonn added a commit that referenced this pull request Jul 13, 2015

Merge pull request #21 from Shyp/dont-crash-invalid-json
api: Don't crash if Slack does not return JSON

@clonn clonn merged commit db1ab36 into clonn:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@clonn

This comment has been minimized.

Copy link
Owner

clonn commented Jul 13, 2015

Thanks @kevinburkeshyp contributed,

@kevinburkeshyp kevinburkeshyp deleted the Shyp:dont-crash-invalid-json branch Jul 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment