Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for ValueError #54

Merged
merged 1 commit into from Jan 9, 2020
Merged

Check for ValueError #54

merged 1 commit into from Jan 9, 2020

Conversation

@jpmelos
Copy link
Contributor

jpmelos commented Jan 9, 2020

ParserError only appears in python-dateutil==2.8.1, and it's a subclass of ValueError.

Checking for ValueError is the safest option, will work in both versions because ParserError subclasses it.

ParserError only appears in 2.8.1, and it's a subclass of ValueError.
@jpmelos jpmelos requested a review from jkemp101 Jan 9, 2020
@jpmelos jpmelos self-assigned this Jan 9, 2020
@jpmelos jpmelos merged commit dc02d9d into master Jan 9, 2020
6 checks passed
6 checks passed
ci/circleci: black Your tests passed on CircleCI!
Details
ci/circleci: test-2.7 Your tests passed on CircleCI!
Details
ci/circleci: test-3.4 Your tests passed on CircleCI!
Details
ci/circleci: test-3.5 Your tests passed on CircleCI!
Details
ci/circleci: test-3.6 Your tests passed on CircleCI!
Details
ci/circleci: test-3.7 Your tests passed on CircleCI!
Details
@jpmelos jpmelos deleted the check-for-value-error branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.