-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How hard would it be to make this work with IE Flexbox? #9
Comments
Right now this polyfill checks if the used browsers supports What you can do is to fork is repo and adjust the checking process. Identify IE 10 and higher disregard the check of support for |
I don't think I'm smart enough to do that, but thanks for taking the time to answer. I really appreciate all the work you put into this polyfill. |
The bug in IE 10 & 11 only affects shorthand rules, though: https://github.com/philipwalton/flexbugs#8-flex-shorthand-doesnt-support-calc |
This is untrue. The bug also affects long hand rules as far as I can tell. <section>
<figure>1</figure>
<figure>2</figure>
</section> * {
background: rgba(0,0,255,0.1);
}
section {
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
}
figure {
-webkit-flex-basis: calc(100% / 2);
-ms-flex-preferred-size: calc(100% / 2);
flex-basis: calc(100% / 2);
} Renders 2 figures at half the size of the viewport in every browser but IE. |
Reopening in hopes someone of higher JS skill than me can contribute. @closingtag feel free to close if you'd like. |
It would be absolutely killer if we could get some proper |
Guys! This will continue here: https://github.com/closingtag/ie-flexbox-calc I will try to update the repo as soon as possible. Stay tuned. |
You're seriously the best polyfill maintainer I've ever met. |
The longform flexbox syntax does with with this polyfill: So Instead of this:
Write this:
Then you can use a separate library for adding vendor prefixes. |
I forget what this bug was about and have stopped paying attention to IE8 completely, but I think there are flexbugs involved with the shorthand forms which might be why I was interested in longhand support. |
Right now IE doesn't support
calc()
inside of any of their Flexbox rules. (e.g.flex: 0 0 calc(100% - 30px)
won't work)Is this something that you could possibly fix?
The text was updated successfully, but these errors were encountered: