Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws.iam-policy - fetch only local policies by default #6815

Closed
ajkerrigan opened this issue Jul 16, 2021 · 2 comments
Closed

aws.iam-policy - fetch only local policies by default #6815

ajkerrigan opened this issue Jul 16, 2021 · 2 comments

Comments

@ajkerrigan
Copy link
Member

i do wonder if we want to do a follow up branch to default to only customer managed policies wrt to server side query.

I cannot comment for all users of this but I'm certainly filtering down to just my customer policies when I am running my policies. A default or some intuitive way to do this would be welcome.

Agreed - the Config source will fetch only local policies by default, that seems intuitive (and much more performant) for the Describe source too. Implementation-wise, it seems that we'd want to:

  • Allow the policy to specify Scope to list_policies
  • Default to Local

This feels similar to how we've handled the ClusterStates server-side filter for EMR. Perhaps we could handle this in a similar way?

Originally posted by @trastle in #6751 (comment)

@kapilt
Copy link
Collaborator

kapilt commented Jul 16, 2021

we can add the static query on to the enumeration as a simpler option, i'm just not clear what use cases there are for custodian on managed policies.

@ajkerrigan
Copy link
Member Author

ajkerrigan commented Aug 12, 2021

This is done (using the static query unless/until there's a need to support AWS-managed policies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants