Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 dependency issues #8057

Closed
2 tasks done
ajkerrigan opened this issue Dec 6, 2022 · 2 comments
Closed
2 tasks done

Python 3.11 dependency issues #8057

ajkerrigan opened this issue Dec 6, 2022 · 2 comments
Labels

Comments

@ajkerrigan
Copy link
Member

ajkerrigan commented Dec 6, 2022

Describe the bug

There are a couple issues with upstream dependencies that break installs under Python 3.11:

Feels like a dependency bump should cover us for policystream. The c7n-gcp/ratelimiter issue has more history than I was aware of, and the best next step isn't clear to me.

What did you expect to happen?

Pip installs of releases and poetry installs at dev time should work under Python 3.11.

Cloud Provider

Amazon Web Services (AWS)

Cloud Custodian version and dependency information

No response

Policy

No response

Relevant log/traceback output

No response

Extra information or context

No response

@kapilt
Copy link
Collaborator

kapilt commented Dec 14, 2022

I think we need to manually excise rate limiter in favor of a more current package. which one I'm not sure, there's a lot of them out there.

@ajkerrigan
Copy link
Member Author

As far as I can tell we're good here now - with the 0.9.21 release I'm seeing clean installs from pip and poetry on 3.11. I've got no real allegiance to a specific ratelimiter package, but pyrate seemed to be actively maintained with solid docs and minimal code changes on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants