Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure - update resource examples in docs #4081

Merged
merged 4 commits into from May 29, 2019

Conversation

erwelch
Copy link
Collaborator

@erwelch erwelch commented May 29, 2019

Addresses: #3868

  • Removes examples irrelevant to the resource
  • Adds some more relevant examples to some of the resources with no other examples
  • Removes notify from all the resource examples

Example rendered docs: https://erwelchsqtest.blob.core.windows.net/cc-docs/html/index.html

@erwelch erwelch added this to To do in azure via automation May 29, 2019
@erwelch erwelch moved this from To do to In progress in azure May 29, 2019
@stefangordon
Copy link
Collaborator

stefangordon commented May 29, 2019

Oh yeah this is waaaay better. Thank you. Now we aren't dropping samples with delete actions to unsuspecting users :)

@cloud-custodian cloud-custodian deleted a comment from erwelch May 29, 2019
@@ -19,38 +19,12 @@ Actions
Example Policies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add the example of finding VMs with public IPs, because that is a common policy.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is under the VM examples!

Copy link
Collaborator

@aluong aluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY very much.

@erwelch erwelch merged commit af5778b into cloud-custodian:master May 29, 2019
azure automation moved this from In progress to Done May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
azure
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants