Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Functionality to add rules to a security group #4973

Open
wants to merge 2 commits into
base: master
from

Conversation

@ajmsra
Copy link

ajmsra commented Oct 21, 2019

Updated code to add rule to a security group. This PR fixes this issue #3220

Ajay Misra added 2 commits Oct 21, 2019
Ajay Misra
@kapilt

This comment has been minimized.

Copy link
Member

kapilt commented Oct 22, 2019

Thanks for the pull request! If you don't mind could you sign the CLA per the developer docs of the ? Direct link here: https://docs.google.com/forms/d/e/1FAIpQLSfwtl1s6KmpLhCY6CjiY8nFZshDwf_wrmNYx1ahpsNFXXmHKw/viewform

@ajmsra

This comment has been minimized.

Copy link
Author

ajmsra commented Oct 22, 2019

@kapilt we have already signed the Corporate Contributor License Agreement v1.0. Please let me know if I need to sign the individual Contributor License Agreement v2.0 as well

@kapilt

This comment has been minimized.

Copy link
Member

kapilt commented Oct 22, 2019

We generally prefer both, as contributor lists from the corporate forms have tended to change over time, it’s easier for the maintainers to verify against the single individual list. Thanks

@ajmsra

This comment has been minimized.

Copy link
Author

ajmsra commented Oct 24, 2019

Thanks, I have now signed the CLA

@kapilt

This comment has been minimized.

Copy link
Member

kapilt commented Oct 30, 2019

thanks for the pr, so we'll need to add tests, and the other part here is whether we should be unifying add/remove into a single set-permissions action similar to what we do with modify-security-groups on a resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.