Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure - cache SDK clients #5041

Closed
wants to merge 15 commits into from

Conversation

@logachev
Copy link
Collaborator

logachev commented Nov 7, 2019

There seems to be some awkward issue with some REST APIs that take some time to reflect changes for all new connections. Some test scenarios are doing CREATE and GET immediately after. If it was done from a single client, it works 100% of time. However, if two different clients were in use GET returns 404 (even if there was successful GET from the same client).

This change should not have any impact on the c7n behavior because generally we use single client version, however in our tests we do create new clients and it causes some one off random failures.

Ran affected tests 200+ times and I had no issues with this cache. We can remove it when we get some response from Azure team.

Main reason is to re-enable nightly tests.

Related issue: Azure/azure-rest-api-specs#7691

@logachev logachev added the cloud/azure label Nov 7, 2019
@aluong
aluong approved these changes Nov 8, 2019
@kapilt

This comment has been minimized.

Copy link
Member

kapilt commented Nov 8, 2019

Is this still subject to the session cache clearing, so that c7n-org multi subscription usage works?

logachev and others added 7 commits Nov 9, 2019
….8.45.3 (#5052)
@logachev logachev closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.