Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws - sechub custom action uses self-select pattern #5042

Merged

Conversation

@kapilt
Copy link
Member

kapilt commented Nov 8, 2019

sans a self-select pattern custodian sec hub actions would receive all actions invokes.

kapilt and others added 2 commits Nov 8, 2019
Copy link
Collaborator

FireballDWF left a comment

lgtm. I've also pulled your branch, and tested it with my workshop custom actions and it works as expected, lambdas of other custom actions not getting invoked anymore, only the lambda matching the custom action name is getting invoked

kapilt added 2 commits Nov 10, 2019
@kapilt kapilt merged commit 118a7ed into cloud-custodian:master Nov 10, 2019
13 checks passed
13 checks passed
Custodian - CI Build #20191110.6 succeeded
Details
Custodian - CI (Container Cask) Container Cask succeeded
Details
Custodian - CI (Docs) Docs succeeded
Details
Custodian - CI (Lint) Lint succeeded
Details
Custodian - CI (Test Python27) Test Python27 succeeded
Details
Custodian - CI (Test Python36) Test Python36 succeeded
Details
Custodian - CI (Test Python37) Test Python37 succeeded
Details
codecov/patch 100% of diff hit (target 89.67%)
Details
codecov/project/azure 92.29% remains the same compared to 022cf8a
Details
codecov/project/custodian Absolute coverage decreased by -0.01% but relative coverage increased by +9.36% compared to 022cf8a
Details
codecov/project/gcp 91.51% remains the same compared to 022cf8a
Details
codecov/project/k8s 93.72% remains the same compared to 022cf8a
Details
codecov/project/mailer 62.06% remains the same compared to 022cf8a
Details
@kapilt kapilt referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.