Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP - audit mode - support event actions and metrics #5156

Merged
merged 7 commits into from Feb 18, 2020

Conversation

@ingwarsw
Copy link
Collaborator

ingwarsw commented Dec 9, 2019

No description provided.

@ingwarsw ingwarsw added the cloud/gcp label Dec 9, 2019
@kapilt kapilt changed the title GCP - audit mode GCP - audit mode - support event actions and metrics Dec 10, 2019
@kapilt

This comment has been minimized.

Copy link
Collaborator

kapilt commented Dec 20, 2019

looks good, the test failure was due to unrelated issue, fixed on trunk, merging that in to see if it resolves ci issues.

@kapilt

This comment has been minimized.

Copy link
Collaborator

kapilt commented Jan 3, 2020

it looks like we'll need a test here, probably can just do a mock/fake one here for coverage.

ingwarsw added 2 commits Feb 10, 2020
@ingwarsw ingwarsw requested a review from kapilt Feb 14, 2020
@kapilt
kapilt approved these changes Feb 18, 2020
Copy link
Collaborator

kapilt left a comment

lgtm, thanks

@kapilt kapilt merged commit fe53e45 into cloud-custodian:master Feb 18, 2020
16 checks passed
16 checks passed
Custodian - CI Build #20200214.6 succeeded
Details
Custodian - CI (Container Cask) Container Cask succeeded
Details
Custodian - CI (Docs) Docs succeeded
Details
Custodian - CI (Lint) Lint succeeded
Details
Custodian - CI (Test Python27) Test Python27 succeeded
Details
Custodian - CI (Test Python36) Test Python36 succeeded
Details
Custodian - CI (Test Python37) Test Python37 succeeded
Details
Custodian - CI (Test Python38) Test Python38 succeeded
Details
Custodian - CI (Test Win2019 Python36) Test Win2019 Python36 succeeded
Details
Custodian - CI (Test Win2019 Python37) Test Win2019 Python37 succeeded
Details
codecov/patch 100% of diff hit (target 89.67%)
Details
codecov/project/azure 92.05% (+0.01%) compared to 8fffea4
Details
codecov/project/custodian Absolute coverage decreased by -0.01% but relative coverage increased by +9.31% compared to 8fffea4
Details
codecov/project/gcp 91.23% remains the same compared to 8fffea4
Details
codecov/project/k8s 93.77% remains the same compared to 8fffea4
Details
codecov/project/mailer 62.33% remains the same compared to 8fffea4
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.