aws - add ssh-key management for iam-users #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapilt
reviewed
Dec 17, 2020
kapilt
reviewed
Dec 21, 2020
kapilt
reviewed
Dec 21, 2020
kapilt
reviewed
Dec 21, 2020
kapilt
reviewed
Dec 21, 2020
kapilt
reviewed
Dec 21, 2020
- filters.ssh-key: Value filter against SSH key properties - actions.remove-ssh-keys: Remove or disable SSH keys
Choose an action name that is more in line with the underlying API and permissions.
- Cosolidate redundant tests - Use a config source to eliminate noise
I had derived from ConfigTest thinking I would use that class's features for subscribing to the config change stream. I didn't end up using that, so the change in base class isn't needed.
ajkerrigan
force-pushed
the
iam-user-ssh-keys
branch
from
121a9fc
to
999e8f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SSH key operations to the "iam-user" resource:
Note that there is some risk of confusing these operations with access key operations. My aim here is to keep the two totally separate with clear enough naming to minimize that risk.