Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump minimum Node.js and NPM versions #2005

Merged
merged 8 commits into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@rockymadden
Copy link
Member

rockymadden commented Mar 12, 2019

Highlights

  • Node.js ^8.10.0 and NPM ^5.6.0 (the version of NPM that comes with Node.js 8.10.0) are now the minimum required versions. Node.js 6 is end-of-life in April of 2019 (next month). Node.js 8.9.0 was the first version of Carbon, the Node.js 8 LTS, however the ecosystem has fairly well standardized on 8.10.0 being the actual minimum version of Node.js 8 LTS in practice.
  • Node.js itself is now a dependency. This magic essentially means Churros is batteries included as far as Node.js and NPM is concerned. Users may have an greater version of Node.js installed locally and Churros will downgrade and work just fine. It also removes the need to use nvm and other node version manager where the user has a greater default version of Node.js and NPM installed. This change also brings more consistent behavior to Churros on desperate machines because all users are now known to use Node.js 8. Lastly, this mitigates against issues with Churros and recent versions of Node.js. For example, Node.js ^11.0.0 currently fails to npm install as is.

Examples

Screenshot

Reference

Closes

@rockymadden rockymadden changed the title build: minimum Node.js version of 8.10.0 build: bump minimum Node and NPM versions Mar 12, 2019

@rockymadden rockymadden changed the title build: bump minimum Node and NPM versions build: bump minimum Node.js and NPM versions Mar 12, 2019

rockymadden added some commits Mar 12, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 12, 2019

Coverage Status

Coverage remained the same at 97.965% when pulling 55f01c1 on feat-pin-node into c68dbc3 on master.

@tyler-cloud-elements
Copy link
Contributor

tyler-cloud-elements left a comment

👏 👏

@patrickdechant patrickdechant merged commit f2c40f5 into master Mar 12, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@patrickdechant patrickdechant deleted the feat-pin-node branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.