12741 replication seq format #76

Merged
merged 1 commit into from Oct 18, 2011

Conversation

Projects
None yet
3 participants
@bdionne

bdionne commented Oct 18, 2011

BugzID:12741

JSON encode the new seq format

@kocolosk

This comment has been minimized.

Show comment Hide comment
@kocolosk

kocolosk Oct 17, 2011

Member

I'm worried about how this will work with plain old integer sequences. Adding quotes around the integers seems like it could screw with CouchDB <=> BigCouch replication.

Member

kocolosk commented on 9c1d679 Oct 17, 2011

I'm worried about how this will work with plain old integer sequences. Adding quotes around the integers seems like it could screw with CouchDB <=> BigCouch replication.

This comment has been minimized.

Show comment Hide comment
@bdionne

bdionne Oct 17, 2011

using couchdb master I've tried replications in both directions, initiating the replication from both bigcouch and couchdb. So far so good

using couchdb master I've tried replications in both directions, initiating the replication from both bigcouch and couchdb. So far so good

This comment has been minimized.

Show comment Hide comment
@rnewson

rnewson Oct 18, 2011

Member

fyi: the iolist_to_binary doesn't appear to be necessary. I replicated fine without it. What's the reason for it?

Member

rnewson replied Oct 18, 2011

fyi: the iolist_to_binary doesn't appear to be necessary. I replicated fine without it. What's the reason for it?

This comment has been minimized.

Show comment Hide comment
@bdionne

bdionne Oct 19, 2011

it probably is belt and suspenders, and an artifact from trying to fix it in full_url, which would be preferable as there are a few other paths thru that code. There's a couple of bugs also in _replicator db so we can revisit it when we fix those.

it probably is belt and suspenders, and an artifact from trying to fix it in full_url, which would be preferable as there are a few other paths thru that code. There's a couple of bugs also in _replicator db so we can revisit it when we fix those.

@kocolosk

This comment has been minimized.

Show comment Hide comment
@kocolosk

kocolosk Oct 18, 2011

Member

As I mentioned on IRC, I'm satisfied that this is safe and the right thing to do. couch_rep_httpc:full_uri/1 calls to_list/1 on the query-string values, so our conversion from integer to binary string won't cause any problems there. Let's merge to master and 0.4.x.

Member

kocolosk commented Oct 18, 2011

As I mentioned on IRC, I'm satisfied that this is safe and the right thing to do. couch_rep_httpc:full_uri/1 calls to_list/1 on the query-string values, so our conversion from integer to binary string won't cause any problems there. Let's merge to master and 0.4.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment