Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
12533 quorum 202 #4
LGTM @bdionne. I reverted your whitespace patch because it was causing a spurious merge conflict with master. If you agree with my whitespace changes can you squash this all down into a single patch and re-submit? Also, I think in this case we're pretty decoupled from the
I think we got our signals crossed here. I was asking you to consider squashing 0b079d4291881b1143c814f5db4847f18204c1c2 into 868e2bd9b00cf7b66528b3c32a6cb5eefb38bafb, but it looks like you threw it away instead. Can you also rewrite the commit message? The body doesn't make much sense once the commit is on master.