Make sure and cleanup spawned db update listeners #54

Merged
merged 1 commit into from Aug 1, 2012

Conversation

Projects
None yet
3 participants
Owner

davisp commented Jul 31, 2012

The showroom_users_cache changes feed exit's ever so often to avoid
"getting stuck". The propogation of the exit signal ended up killing
the fabric_db_update_listener process before it had a chance to cleanup
the processes it spawned on remote nodes.

This patch adds a process that traps exits and calls the cleanup
regardless of how the fabric_db_update_listener finishes (by returning
or if the process disappears). This should fix most of the issue
although it does not fix the issue if the VM dissappears instantaneously
(ie, segfault). For that we need to add something on the remote side
that will flush rexi processes when a node disappears.

@davisp davisp Make sure and cleanup spawned db update listeners
The showroom_users_cache changes feed `exit`'s ever so often to avoid
"getting stuck". The propogation of the `exit` signal ended up killing
the fabric_db_update_listener process before it had a chance to cleanup
the processes it spawned on remote nodes.

This patch adds a process that traps exits and calls the cleanup
regardless of how the fabric_db_update_listener finishes (by returning
or if the process disappears). This should fix most of the issue
although it does not fix the issue if the VM dissappears instantaneously
(ie, segfault). For that we need to add something on the remote side
that will flush rexi processes when a node disappears.
141977e
Owner

kocolosk commented Aug 1, 2012

LGTM

Contributor

bdionne commented Aug 1, 2012

lgtm

kocolosk merged commit 15d00e7 into master Aug 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment