Don't resurrect shards on deletion #35

Merged
merged 1 commit into from Dec 6, 2012

Conversation

Projects
None yet
3 participants
@rnewson
Owner

rnewson commented Dec 4, 2012

In bigcouch and bigcouchplus (at least) the deleted property is a
binary, <<"deleted">>, and not an atom, deleted, as it used to
be. This causes mem3_shards to recreate a shard immediately after it
is deleted, leading to profound silliness.

BugzID: 15924

@davisp

This comment has been minimized.

Show comment Hide comment
@davisp

davisp Dec 4, 2012

Owner

+1 if you export is_deleted/1 from mem3_nodes. +2 if you move it to mem3_util.

Owner

davisp commented Dec 4, 2012

+1 if you export is_deleted/1 from mem3_nodes. +2 if you move it to mem3_util.

Robert Newson
Don't resurrect shards on deletion
In bigcouch and bigcouchplus (at least) the deleted property is a
binary, <<"deleted">>, and not an atom, deleted, as it used to
be. This causes mem3_shards to recreate a shard immediately after it
is deleted, leading to profound silliness.

BugzID: 15924
@bdionne

This comment has been minimized.

Show comment Hide comment
@bdionne

bdionne Dec 4, 2012

+1 nice find

bdionne commented on be6b8af Dec 4, 2012

+1 nice find

rnewson pushed a commit that referenced this pull request Dec 6, 2012

@rnewson rnewson merged commit c0b4303 into master Dec 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment