Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Conversation

@emlaver
Copy link
Contributor

@emlaver emlaver commented Aug 7, 2017

What

Fix changes feed validation to allow for the valid value 0 for since option.

How

  • Fixed exception check so that value 0 for changes feed option since is valid

Testing

Added test case in changes_tests.py

Issues

fixes #297

@emlaver emlaver force-pushed the 297-changes-since-option branch 2 times, most recently from 9050445 to 833095f Compare August 7, 2017 14:43
@smithsz smithsz self-requested a review August 7, 2017 14:45
Copy link
Contributor

@smithsz smithsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ricellis ricellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@emlaver emlaver force-pushed the 297-changes-since-option branch from 833095f to 9b5e532 Compare August 8, 2017 14:21
@emlaver emlaver merged commit 19104ec into master Aug 8, 2017
@ricellis ricellis modified the milestone: 2.6.0 Aug 8, 2017
@emlaver emlaver deleted the 297-changes-since-option branch November 9, 2017 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db.changes() API doesn't allow a since = 0

3 participants