Skip to content

Conversation

@arnaugiralt
Copy link
Member

@arnaugiralt arnaugiralt commented Feb 13, 2024

  • Added conditions to not perform a request is there is no next page or no previous page in the fastApiTableAdapter module.
  • Fixed tools export in package.json, previous config was not correct. Works fine now.
  • Split build and dev (serve) Webpack configs in two files to have a clean configuration when building the project.
  • Changed tools' Webpack config: Removed index export, opting for having two separate files exposed: one for the adapter and one for the composable, so Vue is not required when using the base adapter. Vue is declared as an external dependency, which means it is not bundled with the tools' exports, and it will rely instead on the version of Vue used by the end user.
  • Cleaned up main export, exporting everything directly. Way more readable and clear.

With this PR there are no changes required to use the fastApiTableAdapter:

import { fastApiTableAdapter } from '@cloudblueconnect/connect-ui-toolkit/tools/fastApi';

But to use the Vue composable for the adapter you need to:

import { useFastApiTableAdapter } from '@cloudblueconnect/connect-ui-toolkit/tools/fastApi/vue';

irinanic88
irinanic88 previously approved these changes Feb 13, 2024
paulinaczybir
paulinaczybir previously approved these changes Feb 13, 2024
nerimartinez
nerimartinez previously approved these changes Feb 13, 2024
- Treat 'vue' dependency as a webpack external for tools builds
- Split main webpack config into build and dev(serve) configs
@sonarqubecloud
Copy link

@arnaugiralt arnaugiralt merged commit 253c827 into master Feb 13, 2024
@arnaugiralt arnaugiralt deleted the feat/LITE-29547 branch February 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants