Feature/lite 29476 create menu component #48
Conversation
paulinaczybir
requested review from
arnaugiralt,
irinanic88,
nerimartinez and
riazhski
|
| const showMenu = ref(false) | ||
| const menu = ref(null) | ||
|
|
||
| const toggle = () => { |
There was a problem hiding this comment.
These mutations are like some hooks under the hood, right?
There was a problem hiding this comment.
It's just syntax for writing method in composition API (opposed to option API that we are used to see more :))
| it('toggles menu to true when clicking', () => { | ||
| const wrapper = mount(Menu); | ||
| wrapper.vm.showMenu = false; | ||
| wrapper.vm.toggle(wrapper.vm.showMenu); |
There was a problem hiding this comment.
Just fyi, dom events can be triggered directly instead of calling the fn attached to the listener.
Eg: wrapper.find('.menu-trigger').trigger('click'); will trigger the event listener, calling your function. You could check then that the 'menu-content' element is rendered as a consequence instead of checking the variable's value. Eg: expect(wrapper.find('.menu-content').exists()).toBeTruthy()
No need to change, just a different type of test.
There was a problem hiding this comment.
Thank you! I will leave it as it is and try to use this way when appropriate in the future :)
Added basic version of menu component
Both the button and container for item are customisable, as they are just plain slot elements (so the styles here are of course not important:) )
