Skip to content

Conversation

@paulinaczybir
Copy link
Collaborator

@paulinaczybir paulinaczybir commented Feb 26, 2024

  • fixed menu closing when multiple menus present
  • also add closeOnClickInside prop
Untitled.2.mov

@sonarqubecloud
Copy link

Copy link
Member

@arnaugiralt arnaugiralt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

const handleClickOutside = (event) => {
if (menu.value && !menu.value.contains(event.target)) {
const isClickWithinMenuBounds = event.composedPath().some(el => el === menu.value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@paulinaczybir paulinaczybir merged commit e8eaccb into master Feb 27, 2024
@paulinaczybir paulinaczybir deleted the bugfix/LITE-29655-menu-does-not-close-when-another-menu-is-opened branch February 27, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants