Make defineExtensionConfig aware of Vite's mode #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Refactored
defineExtensionConfigto be a function (see Vite - Conditional configuration), so it can be aware of Vite's mode (development,production) in order to set up source maps and minification properly.This needs to be considered as a breaking change, so the major version of the package will need to be updated. This won't require any change in most cases, since the helper is mostly used directly as the argument to Vite's
defineConfigmethod, but if someone is using that differently, it will require some modifications.The following setup (used on the Connect BI Reporter extension) will work without any changes:
But a setup like the following won't:
It will need to be updated to call
defineExtensionConfigwith Vite's mode: