Skip to content

Conversation

@maxipavlovic
Copy link
Member

No description provided.

@maxipavlovic maxipavlovic requested review from a user, d3rky and vgrebenschikov October 12, 2020 08:09
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #4 into master will decrease coverage by 0.16%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   96.29%   96.12%   -0.17%     
==========================================
  Files          24       24              
  Lines        1107     1111       +4     
==========================================
+ Hits         1066     1068       +2     
- Misses         41       43       +2     
Impacted Files Coverage Δ
dj_cqrs/transport/rabbit_mq.py 85.36% <60.00%> (-1.19%) ⬇️
dj_cqrs/controller/consumer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a930b3e...50d767b. Read the comment docs.

@d3rky
Copy link
Contributor

d3rky commented Oct 12, 2020

I think next step should be Dead Queue with instruments how to move from dq to original queues or remove / delete... Number of messages in DQ can be good for alerts

@d3rky d3rky merged commit 9d3efb3 into cloudblue:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants