support for FieldName__c #4

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
2 participants
@twobitfool

Currently the adapter supports:

  • field_name
  • FieldName
  • field_name__c

FieldName__c has shown up a lot in my travels, and it seems like a reasonable addition to that list.

Thanks.

@jpr5

This comment has been minimized.

Show comment
Hide comment
@jpr5

jpr5 Sep 9, 2011

@two-bit-fool I got this from EngineYard -- can you tell me what circumstances led you to make this change?

@two-bit-fool I got this from EngineYard -- can you tell me what circumstances led you to make this change?

This comment has been minimized.

Show comment
Hide comment
@twobitfool

twobitfool Sep 11, 2011

Owner

@jpr5: The typecast method fires as soon as the property is set, but we don't want to convert it until we are sending values back to Salesforce. Before this change, the following would happen: p Event.gen(:all_day_event => true).all_day_event would respond with 1 instead of true.

Owner

twobitfool replied Sep 11, 2011

@jpr5: The typecast method fires as soon as the property is set, but we don't want to convert it until we are sending values back to Salesforce. Before this change, the following would happen: p Event.gen(:all_day_event => true).all_day_event would respond with 1 instead of true.

@jpr5

This comment has been minimized.

Show comment
Hide comment
@jpr5

jpr5 Sep 9, 2011

@two-bit-fool seems a little heavy-handed .. can you comment on when/how it was getting re-read?

For all the individual spec invocations, I'm thinking of nuking the need to specify full path to spec_helper - that way require 'spec/spec_helper' (or whatever) will only ever load it once. Is this really what led to the above?

jpr5 commented on 6f19c22 Sep 9, 2011

@two-bit-fool seems a little heavy-handed .. can you comment on when/how it was getting re-read?

For all the individual spec invocations, I'm thinking of nuking the need to specify full path to spec_helper - that way require 'spec/spec_helper' (or whatever) will only ever load it once. Is this really what led to the above?

This comment has been minimized.

Show comment
Hide comment
@twobitfool

twobitfool Sep 11, 2011

Owner

@jpr5: My bad. This was needed because of the way that I was requiring spec_helper with a relative path, an old, bad habit. Reverted in commit 1102b33.

Owner

twobitfool replied Sep 11, 2011

@jpr5: My bad. This was needed because of the way that I was requiring spec_helper with a relative path, an old, bad habit. Reverted in commit 1102b33.

@jpr5

This comment has been minimized.

Show comment
Hide comment
@jpr5

jpr5 Sep 9, 2011

@two-bit-fool I think cloudcrowd/dm-salesforce-adapter commit 3578230 might obviate this and your commit 6f19c22, FWIW.

jpr5 commented on 00211fc Sep 9, 2011

@two-bit-fool I think cloudcrowd/dm-salesforce-adapter commit 3578230 might obviate this and your commit 6f19c22, FWIW.

This comment has been minimized.

Show comment
Hide comment
@twobitfool

twobitfool Sep 11, 2011

Owner

@jpr5: I was originally doing this so I could run the spec directly (i.e. ruby some_spec.rb), but I don't do that anymore. I've changed it in commit 66d26ce. Thanks.

Owner

twobitfool replied Sep 11, 2011

@jpr5: I was originally doing this so I could run the spec directly (i.e. ruby some_spec.rb), but I don't do that anymore. I've changed it in commit 66d26ce. Thanks.

twobitfool added some commits Sep 11, 2011

avoid relative paths in require spec_helper
it's not needed (unless you want to run the spec directly)
and since the path is not expanded, the spec_helper runs multiple times
@jpr5

This comment has been minimized.

Show comment
Hide comment
@jpr5

jpr5 Apr 19, 2012

The equivalent of this is now in the main cloudcrowd repository, FYI.

cloudcrowd/dm-salesforce-adapter@e8db767

jpr5 commented on 43670e8 Apr 19, 2012

The equivalent of this is now in the main cloudcrowd repository, FYI.

cloudcrowd/dm-salesforce-adapter@e8db767

@jpr5 jpr5 closed this Sep 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment