New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live (integration) test for app deployment and api key checks. #109

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@inklesspen
Collaborator

inklesspen commented Nov 1, 2017

The test requires certain environment variables to be set; you need to set up a suitable Google Cloud project and acquire credentials before you can run this test.

For this reason, I don't know if we can add it to the CI. Better to run it manually before each release.

@inklesspen inklesspen requested review from kryzthov and tangiel Nov 1, 2017

@inklesspen

This comment has been minimized.

Show comment
Hide comment
@inklesspen

inklesspen Nov 1, 2017

Collaborator

Codecov is clearly on drugs; test utility files should be excluded from coverage anyway, and there's no way this PR is responsible for that function not being called.

Collaborator

inklesspen commented Nov 1, 2017

Codecov is clearly on drugs; test utility files should be excluded from coverage anyway, and there's no way this PR is responsible for that function not being called.

@tangiel

This comment has been minimized.

Show comment
Hide comment
@tangiel

tangiel Nov 1, 2017

Contributor

I think it's technically possible to add it to CI, but I probably wouldn't recommend it.

Contributor

tangiel commented Nov 1, 2017

I think it's technically possible to add it to CI, but I probably wouldn't recommend it.

@tangiel

You're missing OSS headers also.

def cleanup(self):
shutil.rmtree(self.cleanup_path)
def become_apikey_app(self, project_id):

This comment has been minimized.

@tangiel

tangiel Nov 1, 2017

Contributor

I don't understand this name.

@tangiel

tangiel Nov 1, 2017

Contributor

I don't understand this name.

This comment has been minimized.

@inklesspen

inklesspen Nov 1, 2017

Collaborator

The TestAppManager (renamed from TestAppMaker) needs to be told what kind of app to make. We currently have a sample app which uses api keys to protect mutation methods, but I will be helping @kryzthov to add one which uses service account authorization.

This method mutates internal state of the TestAppManager, rather than create a new object, so I named the method become_apikey_app instead of make_apikey_app. Let me know if you have a good alternative, please!

@inklesspen

inklesspen Nov 1, 2017

Collaborator

The TestAppManager (renamed from TestAppMaker) needs to be told what kind of app to make. We currently have a sample app which uses api keys to protect mutation methods, but I will be helping @kryzthov to add one which uses service account authorization.

This method mutates internal state of the TestAppManager, rather than create a new object, so I named the method become_apikey_app instead of make_apikey_app. Let me know if you have a good alternative, please!

This comment has been minimized.

@tangiel

tangiel Nov 1, 2017

Contributor

Can you just add a short comment, for future reference?

@tangiel

tangiel Nov 1, 2017

Contributor

Can you just add a short comment, for future reference?

This comment has been minimized.

@inklesspen

inklesspen Nov 1, 2017

Collaborator

Added.

@inklesspen

inklesspen Nov 1, 2017

Collaborator

Added.

Add live (integration) test for app deployment and api key checks.
The test requires certain environment variables to be set; you need to
set up a suitable Google Cloud project and acquire credentials before
you can run this test.

@cloudendpoints cloudendpoints deleted a comment from codecov-io Nov 1, 2017

@tangiel

tangiel approved these changes Nov 1, 2017

@inklesspen inklesspen merged commit 4e78d32 into cloudendpoints:master Nov 1, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@inklesspen inklesspen deleted the inklesspen:livetest branch Nov 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment