CDP PvC DS Pre-Check #2
Conversation
…ual usage Updated ReadMe.md Refactored entirety of preinstall_check.py reducing overall SLOC by 30% Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
correctly write cells to xlsxwriter Add basic logging support Add passwordless SSH check at start of script Simplify ECS check sequencing logic Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
Reordered top level check sequence to make it easy to comment checks you want to skip Moved SSH errors check to static value at top of Handler class Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
refactoring
There was a problem hiding this comment.
Hi @Nishant-K-Raj
cc) @Chaffelson
I ran this PvC DS pre-checker utility on a small, test cluster. It's a great tool with some very informative output - thanks! Below is some feedback that might be helpful to improve the tool.
Just to note that my execution was running from my laptop which had passwordless ssh to all nodes in the cluster. Also, I was mainly looking from the point-of-view of usability and the contents of output rather than the type of checks performed.
Some improvements that would make the tool easier for my use-case:
- A requirements.txt file with dependency Python packages would be good to include.
- If it was possible to specify the input parameters in an input configuration file rather than editing the source directly, that would make the setup and reuse of the code easier.
- For SSH to the remote nodes it would be nice to be able to optionally specify the username to be used with the SSH and SCP commands.
- Also the option to disable SSH host key checking would be nice.
Thanks,
Jim
|
|
||
| ``` | ||
|
|
||
| ## Configure: |
There was a problem hiding this comment.
A note here about where these configuration settings should be made (in the preinstall_check.py script) would be good to include.
| "ecs-5.company.com"] | ||
|
|
||
| # Define Postgres ECS DB Host | ||
| postgres_host = "ecs-db-host.company.com" |
There was a problem hiding this comment.
The postgres_host setting does not seem to be supported in the code.
* CDP PvC DS Pre-Check * renamed version_check.py to preinstall_check.py to better reflect actual usage Updated ReadMe.md Refactored entirety of preinstall_check.py reducing overall SLOC by 30% Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com> * Correctly quote spaces in cluster names correctly write cells to xlsxwriter Add basic logging support Add passwordless SSH check at start of script Simplify ECS check sequencing logic Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com> * Added dns check for provided hostnames to fail early Reordered top level check sequence to make it easy to comment checks you want to skip Moved SSH errors check to static value at top of Handler class Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com> Co-authored-by: Daniel Chaffelson <chaffelson@gmail.com> Co-authored-by: @Nishant-K-Raj
CDP PvC DS Pre-Check