Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rename JobControl and ControlledJob #26

Merged
merged 2 commits into from May 15, 2012

Conversation

Projects
None yet
2 participants
Contributor

gabrielreid commented May 15, 2012

Renamed ControlledJob and JobControl to CrunchControlledJob and CrunchJobControl, respecitively, to avoid naming collisions with core hadoop classes in CDH3u4.

These two classes are near copies of the same class (with the same package) in hadoop-core. In CDH3u4, these two classes became available with exactly the same package and name as in Crunch, causing a naming collision. As the core hadoop classes are loaded first, this breaks Crunch in CDH3u4.

In the future we should move to make use of the ControlledJob and JobControl that are available in hadoop-core, but doing this right now would break compatibility with anything before CDH3u4.

Gabriel Reid and others added some commits May 15, 2012

Gabriel Reid Renamed ControlledJob and JobControl to CrunchControlledJob and
CrunchJobControl to avoid naming collisions with core hadoop classes
in CDH3u4.
c30606c
@gabrielreid gabrielreid Make UnionCollectionTest order-independent
Remove the assumption in unit test that contents of a UnionCollection
are in a specific order.
95a75f2
Contributor

jwills commented May 15, 2012

Thank you Gabe-- those Cloudera guys are always trying to screw me up. ;-)

@jwills jwills added a commit that referenced this pull request May 15, 2012

@jwills jwills Merge pull request #26 from gabrielreid/master
Rename JobControl and ControlledJob
b6a1c4c

@jwills jwills merged commit b6a1c4c into cloudera:master May 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment