Renamed Crunch's type package to types to prevent issues in scala. #27

Merged
merged 1 commit into from May 23, 2012

2 participants

@robotoer

As the summary says.

@jwills

So I hesitate on this one, as this will break all of the existing Java code that expects the type.* package. You have a use case where using the type trick won't work in Scala?

@robotoer

I haven't encountered any huge problems with the type package, just issues coming from certain tools(intellij's idea) not having support for imports with escaped packages. All in all, having to import the type package with type just feels like a hack.

I understand entirely if you decide not to accept this change, I just thought it would be a good idea to at least bring it up before this becomes an apache incubator project.

@jwills

I'll start an email thread with the other initial committers and cc crunch-dev so folks can weigh in on it. I think we need to do it, it's mostly a question of when.

@jwills jwills merged commit d243a1a into cloudera:master May 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment