Fix casting/rounding error for size calculation #32

Merged
merged 6 commits into from May 26, 2012

Projects

None yet

3 participants

@gabrielreid
Contributor

Correct a casting/rounding error which resulted in any collection which used an operation that had a scale factor smaller than zero (e.g. FilterFn) reporting a size of 0.

Also included are some changes that are similar to the changes that Christian did in pull request #31. His changes aren't merged here (yet) as the use of -1 for the size of non-existant files is to be reviewed.

gabrielreid added some commits May 24, 2012
@gabrielreid gabrielreid Merge branch 'sourcetarget-npe' 0b25d1e
@gabrielreid gabrielreid Merge remote-tracking branch 'upstream/master' 6d89646
@gabrielreid gabrielreid Fix casting/rounding error for size calculation
Correct a casting/rounding error which resulted in any collection
which used an operation that had a scale factor smaller than zero
(e.g. FilterFn) reporting a size of 0.
6d48734
@gabrielreid gabrielreid Add tests for creation of CompositePathIterable
Test cases for various scenarios of file status when creating
a CompositePathIterable
bd05320
Contributor
tzolov commented May 26, 2012

The CompositePathIterable modifications in #32 and #31 appear identical. I like though the way #32 handles the (stati.length == 0) case.

Contributor
jwills commented May 26, 2012

Hey Gabriel-- just pulled in Chris' change for -1 on the file size. Can you merge the updates? Agree re: Chris' comments on CompositePathIterable on stati.length == 0.

Contributor

Hey Josh, I've merged Chris' changes, and it's all ready to go now.

Contributor
jwills commented May 26, 2012

Yay-- thanks!

@jwills jwills merged commit e4b7c16 into cloudera:master May 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment