Fix for FLUME-625 #10

Open
wants to merge 4 commits into from

2 participants

@joscha

when loading classes after defining plugins within flume-site.xml
(e.g. line breaks at the beginning or end of the tag, after
auto-formatting)

@joscha joscha FLUME-625: Adds filtering for white spaces, which produced hick-ups
when loading classes after defining plugins within flume-site.xml
(e.g. line breaks at the beginning or end of the <value> tag, after
auto-formatting)
fb2fb15
@jmhsieh
Cloudera member

Hey joscha,

Thanks for the patch! Look good and straight forward but I need three quick things before I can commit (see https://github.com/cloudera/flume/wiki/HowToContribute for more details):

1) Can you add a unit test? It should be really simple. Instantiate a configuration, set PLUGIN_CLASSES with something with spaces in various places, and then check the output.

2) I need a statement saying that we you give Cloudera permission to include this patch.

3) Please include a link in the issue tracker jira. I generally don't use github pulls but since this is small and if this is public with persistent url let's give this a try. (Normally we use review board but github seems a bit improved since last time I tried it).

Thanks,
Jon.

@joscha

Added 4 unit tests to flume-core/src/test/java/com/cloudera/flume/conf/TestFlumeConfiguration.java.
JIRA issue is https://issues.cloudera.org/browse/FLUME-625

@joscha joscha closed this May 2, 2011
@joscha joscha reopened this May 2, 2011
@jmhsieh
Cloudera member

This looks good to me.

@wingsh wingsh pushed a commit that referenced this pull request May 30, 2011
@gnkr8 gnkr8 Fixes #10 fbe8c19
@joscha

I grant license to Cloudera for inclusion in Cloudera works (as per the Apache License §5)

@joscha

Any news on the inclusion of this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment