[ui] Also patch another jquery.notify plugin (#2006)

Fix bug using _this and not this. Make sure we check the message post XSS and tags stripping.
cloudera · Apr 15, 2021 · 1095d02 · 1095d02
1 parent 6945f58
commit 1095d02
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/desktop/core/src/desktop/js/jquery/plugins/jquery.notify.js b/desktop/core/src/desktop/js/jquery/plugins/jquery.notify.js
@@ -53,8 +53,8 @@ Plugin.prototype.show = function () {
   _this.options.message = _this.options.message.replace(/(<([^>]+)>)/gi, ''); // escape HTML messages
   _this.options.message = hueUtils.deXSS(_this.options.message); // escape XSS messages
 
-  if (/^(504|upstream connect error)/.test(this.options.message)) {
-    console.warn(this.options.message);
+  if (/^(504|upstream connect error|Gateway Time-out)/.test(_this.options.message.trim())) {
+    console.warn(_this.options.message);
     return;
   }
 

diff --git a/desktop/core/src/desktop/static/desktop/js/jquery.notify.js b/desktop/core/src/desktop/static/desktop/js/jquery.notify.js
@@ -48,6 +48,11 @@
     var _this = this;
     var MARGIN = 4;
 
+    if (/^(504|upstream connect error|Gateway Time-out)/.test(_this.options.message.trim())) {
+      console.warn(_this.options.message);
+      return;
+    }
+
     _this.options.message = _this.options.message.replace(/(<([^>]+)>)/ig, ''); // escape HTML messages
     _this.options.message = hueUtils.deXSS(_this.options.message); // escape XSS messages