Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Double-check https ingress trailing dash
Dash on end was breaking manifest, tested with helm template
  • Loading branch information
gmsantos authored and romainr committed May 6, 2021
1 parent 9b98a35 commit d9fa32f
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
16 changes: 8 additions & 8 deletions tools/kubernetes/helm/hue/templates/ingress-https-v1.yaml
Expand Up @@ -13,11 +13,11 @@ metadata:
nginx.ingress.kubernetes.io/session-cookie-name: "hue-balancer"
nginx.ingress.kubernetes.io/session-cookie-expires: "172800"
nginx.ingress.kubernetes.io/session-cookie-max-age: "172800"
{{- if .Values.ingress.hasAuth -}}
{{- if .Values.ingress.hasAuth }}
nginx.ingress.kubernetes.io/auth-type: basic
nginx.ingress.kubernetes.io/auth-secret: basic-auth-hue
nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
{{- end -}}
{{- end }}
{{- with .Values.ingress.annotations }}
{{ toYaml . | indent 4 }}
{{- end }}
Expand All @@ -26,15 +26,15 @@ spec:
- host: {{ .Values.ingress.domain }}
http:
paths:
{{ if .Values.websocket.enabled }}
{{- if .Values.websocket.enabled }}
- backend:
service:
name: daphne-websocket
port:
number: 8001
pathType: ImplementationSpecific
path: /(ws/.*)
{{- end -}}
{{- end }}
- backend:
service:
name: hue-balancer
Expand Down Expand Up @@ -69,11 +69,11 @@ spec:
tls:
- hosts:
- {{ .Values.ingress.domain }}
{{- range .Values.ingress.extraHosts -}}
{{- range .Values.ingress.extraHosts }}
- {{ . | quote }}
{{- end -}}
{{- if .Values.api.enabled -}}
{{- end }}
{{- if .Values.api.enabled }}
- {{ .Values.api.domain }}
{{- end -}}
{{- end }}
secretName: letsencrypt-hue-prod-tls
{{- end -}}
20 changes: 10 additions & 10 deletions tools/kubernetes/helm/hue/templates/ingress-https-v1beta.yaml
Expand Up @@ -13,11 +13,11 @@ metadata:
nginx.ingress.kubernetes.io/session-cookie-name: "hue-balancer"
nginx.ingress.kubernetes.io/session-cookie-expires: "172800"
nginx.ingress.kubernetes.io/session-cookie-max-age: "172800"
{{- if .Values.ingress.hasAuth -}}
{{- if .Values.ingress.hasAuth }}
nginx.ingress.kubernetes.io/auth-type: basic
nginx.ingress.kubernetes.io/auth-secret: basic-auth-hue
nginx.ingress.kubernetes.io/auth-realm: 'Authentication Required'
{{- end -}}
{{- end }}
{{- with .Values.ingress.annotations }}
{{ toYaml . | indent 4 }}
{{- end }}
Expand All @@ -26,12 +26,12 @@ spec:
- host: {{ .Values.ingress.domain }}
http:
paths:
{{ if .Values.websocket.enabled }}
{{- if .Values.websocket.enabled }}
- backend:
serviceName: daphne-websocket
servicePort: 8001
path: /(ws/.*)
{{- end -}}
{{- end }}
- backend:
serviceName: hue-balancer
servicePort: 80
Expand All @@ -45,23 +45,23 @@ spec:
servicePort: 80
path: /
{{- end }}
{{ if .Values.api.enabled }}
{{- if .Values.api.enabled }}
- host: {{ .Values.api.domain }}
http:
paths:
- backend:
serviceName: hue-api
servicePort: 8005
path: /
{{ end }}
{{- end }}
tls:
- hosts:
- {{ .Values.ingress.domain }}
{{- range .Values.ingress.extraHosts -}}
{{- range .Values.ingress.extraHosts }}
- {{ . | quote }}
{{- end -}}
{{- if .Values.api.enabled -}}
{{- end }}
{{- if .Values.api.enabled }}
- {{ .Values.api.domain }}
{{- end -}}
{{- end }}
secretName: letsencrypt-hue-prod-tls
{{- end -}}

0 comments on commit d9fa32f

Please sign in to comment.