[docker] About 60% docker image size reduce (1.2GB -->> 480MB) #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…B, compressed status) 1, merge docker build step to reduce docker image layer 2, apt and pip install without cache storage 3, directory desktop/core/ext-py/ add to docker layer but delete it at Dockerfile, so add it to .dockerignore 4, node.js 10.x is no longer actively supported! upgrade to 14 5, FIX comment issue at Dockerfile L74: "threadloop # Needed for Jaeger \", this make pip explain the follow line as comment 6, FIX Clickhouse "Can't load plugin: sqlalchemy.dialects:clickhouse" by pip install sqlalchemy-clickhouse
ymping
changed the title
|
This looks great! |
romainr
approved these changes
May 18, 2021
|
And already live on https://demo.gethue.com/
|
|
One follow-up #2141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I am using hue in my company production environment. At the beginning, i used the official docker image pull from docker hub, but Clickhouse query not work, missing something python package. so i try to build from source code and install the missing python package. when i clone the repo and get the Dockerfile, there are many improvements can do as a professional devops engineer, so just do it.
What changes were proposed in this pull request?
How was this patch tested?