Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVY-182. Add SPARK_HOME/conf to classpath when SPARK_CONF_DIR is not… #296

Closed
wants to merge 1 commit into from

Conversation

jonalter
Copy link
Contributor

… defined

LIVY-182

@codecov-io
Copy link

Codecov Report

Merging #296 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
+ Coverage     70.57%   70.59%   +0.02%     
- Complexity      670      673       +3     
============================================
  Files            92       92              
  Lines          4812     4812              
  Branches        720      720              
============================================
+ Hits           3396     3397       +1     
+ Misses          927      923       -4     
- Partials        489      492       +3
Impacted Files Coverage Δ Complexity Δ
...in/java/com/cloudera/livy/rsc/ContextLauncher.java 80.93% <ø> (-2.12%) 19% <ø> (ø)
.../java/com/cloudera/livy/rsc/driver/JobWrapper.java 80.64% <ø> (ø) 8% <ø> (+1%)
...n/java/com/cloudera/livy/rsc/driver/RSCDriver.java 77.58% <ø> (+1.29%) 40% <ø> (+1%)
.../java/com/cloudera/livy/rsc/rpc/RpcDispatcher.java 69.56% <ø> (+3.26%) 20% <ø> (+1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c434c...f3fcbe8. Read the comment docs.

@alex-the-man
Copy link
Contributor

Mind if I ask what's this change for?
We are planning to add multiple SPARK_HOME supports. We might need to do this in another way so it works with #232.

@jonalter
Copy link
Contributor Author

You are correct. Also, #232 fixes this issue (see line 207 here: https://github.com/cloudera/livy/pull/232/files#diff-bc70dcf9c8f35cb4efd2f347bb004a9fR193)
Closing this PR and Ticket.

@jonalter jonalter closed this Feb 23, 2017
@jonalter jonalter deleted the LIVY-182 branch February 23, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants