Add highlighting to Primer JSON snippets #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucperkins <lucperkins@gmail.com>
|
Aside from some indenting difference, what's changed? I'm not see it |
|
@duglin The JSON snippets now have syntax highlighting, which IMO is an important readability improvement |
|
It is browser specific thing? Or a plugin? I don't see anything special: |
|
@duglin Syntax highlighting is observed throughout the other documents in the spec. This PR is meant only to standardize the primer. |
|
I'm not against adding the json tags, I'm just curious to see where it would show up since I've never seen it taken into account in a browser |
|
Without highlighting:
With highlighting:
AFAIK it isn't browser specific. Again, I'm only enforcing standardization across the code samples in the spec. |
|
LGTM |
Vlaaaaaaad
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the CE primer a tiny bit prettier via syntax highlighting.