New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double insert on DOMContentLoaded #3

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@avidal
Contributor

avidal commented Sep 10, 2018

Sometimes, the DOMContentLoaded event may fire twice (notably, there's a strange intersection between the apps bundle and rocket loader that may cause this). So, we only initialize on DCL once by checking the flag.

Avoid double insert on DOMContentLoaded
Sometimes, the `DOMContentLoaded` event may fire twice (notably, there's a strange intersection between the apps bundle and rocket loader that may cause this). So, we only initialize on DCL once by checking the flag.

@mpint mpint merged commit b0e1101 into cloudflare-apps:master Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment