New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make resources not required in the schema #1

Merged
merged 3 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@victoriabernard92
Copy link
Member

victoriabernard92 commented Jan 2, 2019

No description provided.

@victoriabernard92
Copy link
Member

victoriabernard92 left a comment

Fix install Schema

@@ -389,7 +388,7 @@
"title": "Name of the DNS Record.",
"description": "For example sub for sub.example.com max length: 255"
},
"contents": {
"content": {

This comment has been minimized.

@avidal

avidal Jan 2, 2019

This changes the name of the property. Doesn't that immediately invalidate all existing install.json since the property name is changing? What's the purpose?

This comment has been minimized.

@victoriabernard92

victoriabernard92 Jan 2, 2019

Member

This was originally a type it should have always been content not contents.

@victoriabernard92 victoriabernard92 merged commit 3b180bb into master Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment