Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go 1.14 to the CI #1092

Merged
merged 6 commits into from Mar 26, 2020
Merged

Add go 1.14 to the CI #1092

merged 6 commits into from Mar 26, 2020

Conversation

@claucece
Copy link
Contributor

claucece commented Mar 23, 2020

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 23, 2020

Codecov Report

Merging #1092 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1092   +/-   ##
=======================================
  Coverage   56.29%   56.29%           
=======================================
  Files          77       77           
  Lines        7294     7294           
=======================================
  Hits         4106     4106           
  Misses       2720     2720           
  Partials      468      468           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abef926...fa3bdcd. Read the comment docs.

@claucece

This comment has been minimized.

Copy link
Contributor Author

claucece commented Mar 24, 2020

This PR also adds version 1.14 to the go.mod and to the dockerfiles.

@lgarofalo

This comment has been minimized.

Copy link
Member

lgarofalo commented Mar 24, 2020

Got a conflict from merging #1080

claucece added 5 commits Mar 23, 2020
@claucece claucece force-pushed the claucece:master branch from 3147fe3 to fa3bdcd Mar 25, 2020
@claucece

This comment has been minimized.

Copy link
Contributor Author

claucece commented Mar 25, 2020

It should be updated now @lgarofalo ;)

@lgarofalo

This comment has been minimized.

Copy link
Member

lgarofalo commented Mar 25, 2020

I was comparing to this PR https://github.com/cloudflare/cfssl/pull/1084/files

I think we should add the

    - arch: s390x
      go: 1.14.x

And bump the Dockerfile.alpine as well.

@lgarofalo lgarofalo mentioned this pull request Mar 25, 2020
.travis.yml Outdated
@@ -5,6 +5,7 @@ matrix:
include:
- go: 1.12.x
- go: 1.13.x
- go: 1.14

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Mar 25, 2020

It should be 1.14.x to introduce the latest 1.14.1

Suggested change
- go: 1.14
- go: 1.14.x

This comment has been minimized.

Copy link
@claucece

claucece Mar 25, 2020

Author Contributor

Done! ;)

@@ -1,4 +1,4 @@
FROM golang:1.13.3-alpine3.10@sha256:40278d43a27b6e0563fcc4dd52c991a25741b1a775402aea342ab9a80158e69e as builder
FROM golang:1.13.3-alpine3.10@sha256:f98761ca3b0855d554085eac8a55e6162f859b3f409c68fa4a7e3302c9d8bf5f as builder

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Mar 25, 2020

Suggested change
FROM golang:1.13.3-alpine3.10@sha256:f98761ca3b0855d554085eac8a55e6162f859b3f409c68fa4a7e3302c9d8bf5f as builder
FROM golang:1.14.1-alpine3.11@sha256:244a736db4a1d2611d257e7403c729663ce2eb08d4628868f9d9ef2735496659 as builder

This comment has been minimized.

Copy link
@claucece

claucece Mar 25, 2020

Author Contributor

Done! ;)

This comment has been minimized.

Copy link
@chenrui333
@lgarofalo lgarofalo merged commit f30ae6a into cloudflare:master Mar 26, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.