bundler: temporarily remove leafRSA3072 testcases.
#1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `leafRSA3072` test file, (`bundler/testdata/cfssl-leaf-rsa3072.pem`) expired and breaks tests. A proper fix would be to regenerate this test file but in the meantime removing the testcases fixes CI.
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
=======================================
Coverage 56.27% 56.27%
=======================================
Files 77 77
Lines 7309 7309
=======================================
Hits 4113 4113
Misses 2727 2727
Partials 469 469 Continue to review full report at Codecov.
|
|
Hi Cloudflare team, Thoughts one merging this PR? It looks good to me and fixes tests that are currently failing. |
|
We can merge this to unblock you today and we will look into regenerating the certificate (dynamically preferably) in a future PR. |
mihirjham
approved these changes
Jun 10, 2020
eiginn
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
leafRSA3072test file, (bundler/testdata/cfssl-leaf-rsa3072.pem) expired and breaks tests. A proper fix would be to regenerate this test file but in the meantime removing the testcases fixes CI.This branch also updates
TestBundleFromFileto print the filename of the failing certificate when there is a bundling error. This may help identify which piece of testdata is at fault when CI fails.Resolves #1110