feat(authsign): store additional metadata/fields in certdb
#1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickysemenza
force-pushed
the
store-metadata-in-certdb
branch
from
26ba928
to
329659c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
- Coverage 56.27% 54.87% -1.40%
==========================================
Files 77 77
Lines 7309 6620 -689
==========================================
- Hits 4113 3633 -480
+ Misses 2727 2532 -195
+ Partials 469 455 -14
Continue to review full report at Codecov.
|
nickysemenza
requested review from
mihirjham,
maxnystrom,
jmunson and
lgarofalo
mihirjham
approved these changes
Sep 14, 2020
lgarofalo
approved these changes
Sep 14, 2020
eiginn
reviewed
Sep 14, 2020
| ADD COLUMN tags bytea, | ||
| ADD COLUMN common_name bytea, | ||
| ADD COLUMN filename bytea, | ||
| ADD COLUMN application_name bytea; |
There was a problem hiding this comment.
Maybe we should start the process of not using bytea type where it doesn't make sense, starting with these new columns.
There was a problem hiding this comment.
Yeah, I'll update the pg + mysql migrations to be TEXT
This is a major change in that the included DB migrations *must* be run before the new version of `cfssl` is deployed. This allows for clients (i.e. https://github.com/cloudflare/certmgr) to send some additional optional fields to `/api/v1/cfssl/authsign` to be stored in `certdb`. It also starts saving SANs, common name, and NotBefore from the issued certificates so that they can be queried without having to parse the PEM.
nickysemenza
force-pushed
the
store-metadata-in-certdb
branch
from
329659c
to
35f9d5c
Compare
maxnystrom
approved these changes
Sep 15, 2020
nickysemenza
force-pushed
the
store-metadata-in-certdb
branch
from
b856b0a
to
73ca13a
Compare
|
updated to move these arbitrary fields into a json column |
nickysemenza
requested review from
lgarofalo,
maxnystrom,
mihirjham and
eiginn
jmunson
approved these changes
Sep 21, 2020
nickysemenza
force-pushed
the
store-metadata-in-certdb
branch
from
e23b413
to
5c528a8
Compare
mihirjham
approved these changes
Sep 24, 2020
nickysemenza
added a commit
to nickysemenza/cfssl
that referenced
this pull request
Oct 13, 2020
Rows inserted before the migration in cloudflare#1126 will have the `common_name` set to NULL. This fixes selects for those rows.
nickysemenza
added a commit
that referenced
this pull request
Oct 13, 2020
fix selecting rows created before migration introduced in #1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is a major change in that the included DB migrations must be run before the new version of
cfsslis deployed.This allows for clients (i.e. https://github.com/cloudflare/certmgr) to send some additional optional fields to
/api/v1/cfssl/authsignto be stored incertdb. It also starts saving SANs, common name, and NotBefore from the issued certificates so that they can be queried without having to parse the PEM.