Skip to content

Nick/nf #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kisom merged 3 commits into from
Jun 25, 2015
Merged

Nick/nf #249

kisom merged 3 commits into from
Jun 25, 2015

Conversation

@grittygrease
Copy link
Contributor

@grittygrease grittygrease commented Jun 25, 2015

Add the name filter commits.

@kisom kisom added this to the Release 1.1 milestone Jun 25, 2015
@kisom kisom added the feature label Jun 25, 2015
kisom
kisom reviewed Jun 25, 2015
View reviewed changes
doc/api.txt Outdated
Copy link
Contributor

@kisom kisom Jun 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

                 "name_whitelist": "^[\w_-]*\.cloudflare.com$",

(See this and this.)

@kisom
Copy link
Contributor

kisom commented Jun 25, 2015

LGTM, waiting on tests.

kisom added a commit that referenced this pull request Jun 25, 2015
@kisom
Merge pull request #249 from cloudflare/nick/nf
ae189ab 
Add name filtering to configuration file.
@kisom kisom merged commit ae189ab into master Jun 25, 2015
@kisom kisom deleted the nick/nf branch June 25, 2015 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

Release 1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@grittygrease @kisom