[Network Analytics] Fix start and end date computation #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cljoly
requested review from
a team,
jherre,
soheiokamoto and
tlozoot
as code owners
The Graphql query expects a `start_date` that’s before the `end_date`. However, in the current example, this condition is not met, resulting in no data being returned. This change ensures that: 1. we have `historical_days` days of data, and 2. the most recent day used is `offset_days` in the past. Also, rename `get_date` to `get_past_date` for clarity.
pedrosousa
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Graphql query expects a
start_datethat’s before theend_date.However, in the current example, this condition is not met, resulting in
no data being returned.
This change ensures that:
historical_daysdays of data, andoffset_daysin the past.