Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network Analytics] Fix start and end date computation #2754

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Nov 19, 2021

The Graphql query expects a start_date that’s before the end_date.
However, in the current example, this condition is not met, resulting in
no data being returned.

This change ensures that:

  1. we have historical_days days of data, and
  2. the most recent day used is offset_days in the past.

@pedrosousa pedrosousa self-assigned this Nov 19, 2021
The Graphql query expects a `start_date` that’s before the `end_date`.
However, in the current example, this condition is not met, resulting in
no data being returned.

This change ensures that:
1. we have `historical_days` days of data, and
2. the most recent day used is `offset_days` in the past.

Also, rename `get_date` to `get_past_date` for clarity.
@pedrosousa pedrosousa merged commit ed2b523 into cloudflare:production Nov 19, 2021
@cljoly cljoly deleted the nav1-fix branch November 19, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants