-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(Ruleset): Add DeleteRulesetRule() #2833
Conversation
changelog detected ✅ |
thanks for this @tlimoncelli! if you don't already know, there is a next generation of this library that we're building from our OpenAPI schemas and is automatically kept in sync - https://github.com/cloudflare/cloudflare-go/tree/next (we're at v2.x at the moment but major verisons will be coming thick and fast as we iterate and stabilise the schemas). the rulesets library definitions can be seen at https://github.com/cloudflare/cloudflare-go/blob/next/api.md#rulesets if you're interested. |
Thanks! I'll plan on moving to that in the future. |
Oops! I should have noticed this earlier. I see you moved the 2 string parameters into DeleteRulesetRuleParams struct. However the 2 fields aren't exported. How does one create a DeleteRulesetRuleParams? |
This functionality has been released in v0.102.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Add DeleteRulesetRule() to delete an individual rule of a ruleset.
Has your change been tested?
This was tested as part of https://github.com/StackExchange/dnscontrol which is currently running with a fork of cloudflare-go. With this PR, DNSControl will no longer require the fork.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.